From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/2] Clean up MADT Table Creation (v2) Date: Wed, 10 Jun 2009 15:29:26 +0300 Message-ID: <4A2FA726.7000102@redhat.com> References: <1244562923-4336-1-git-send-email-eak@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Beth Kon Return-path: Received: from mx2.redhat.com ([66.187.237.31]:53609 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754922AbZFJM31 (ORCPT ); Wed, 10 Jun 2009 08:29:27 -0400 In-Reply-To: <1244562923-4336-1-git-send-email-eak@us.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: Beth Kon wrote: > This patch is based on the recent patch from Vincent Minet. I split Vincent's > changes into 2 patches (to separate MADT and RSDT table cleanup, as suggested by > Marcelo) and added a bit to them. > > There has been much ado over the acpi_bios_init function recently. I had actually > done a rewrite very similar to Gleb's, but Avi argued that the rewrite has to be > more incremental. This patch contains minimal changes without any rewrite because > the changes are kvm-only. The rewrite would better be a separate step, submitted to > qemu and then merged into kvm. > > I am submitting the RSDT fix to kvm because the kvm and qemu RSDT implementation differs. > Again, as a separate rewrite effort, the kvm and qemu RSDT manipulation could be merged > into one base as a later, separate step. > > This patch will get MADT into reasonable enough shape for me to resubmit hpet patches > on top of it. After that, I'd be willing to submit incremental rewrite patches for > acpi_bios_init to qemu, starting with MADT and RSDT. > > Applied both, thanks. -- error compiling committee.c: too many arguments to function