From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/4] cleanup mmio coalescing functions Date: Thu, 11 Jun 2009 12:19:29 +0300 Message-ID: <4A30CC21.6000309@redhat.com> References: <1244664293-9502-1-git-send-email-glommer@redhat.com> <1244664293-9502-2-git-send-email-glommer@redhat.com> <1244664293-9502-3-git-send-email-glommer@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Glauber Costa Return-path: Received: from mx2.redhat.com ([66.187.237.31]:38942 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754069AbZFKJTc (ORCPT ); Thu, 11 Jun 2009 05:19:32 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n5B9JZIH020057 for ; Thu, 11 Jun 2009 05:19:35 -0400 In-Reply-To: <1244664293-9502-3-git-send-email-glommer@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Glauber Costa wrote: > remove wrappers that existed only due to qemu/libkvm separation. > Use qemu types for function definitions. > > > -int kvm_register_coalesced_mmio(kvm_context_t kvm, uint64_t addr, uint32_t size) > +int kvm_coalesce_mmio_region(target_phys_addr_t addr, ram_addr_t size) > { > #ifdef KVM_CAP_COALESCED_MMIO > + kvm_context_t kvm = kvm_context; > While all this code is doomed, please maintain consistent indentation while it lives. > struct kvm_coalesced_mmio_zone zone; > int r; > > @@ -1121,9 +1122,10 @@ int kvm_register_coalesced_mmio(kvm_context_t kvm, uint64_t addr, uint32_t size) > return -ENOSYS; > } > > -int kvm_unregister_coalesced_mmio(kvm_context_t kvm, uint64_t addr, uint32_t size) > +int kvm_uncoalesce_mmio_region(target_phys_addr_t addr, ram_addr_t size) > { > #ifdef KVM_CAP_COALESCED_MMIO > + kvm_context_t kvm = kvm_context; > Here too. -- error compiling committee.c: too many arguments to function