public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] Replace pending exception by PF if it happens serially.
Date: Sun, 14 Jun 2009 14:01:37 +0300	[thread overview]
Message-ID: <4A34D891.4080104@redhat.com> (raw)
In-Reply-To: <20090611082611.GA18996@redhat.com>

Gleb Natapov wrote:
> Replace previous exception with a new one in a hope that instruction
> re-execution will regenerate lost exception.
>
>   

Applied, thanks.

> +		switch(vcpu->arch.exception.nr) {
> +		case DF_VECTOR:
>  			/* triple fault -> shutdown */
>  			set_bit(KVM_REQ_TRIPLE_FAULT, &vcpu->requests);
>   

Added a 'return' here.  It will work without, but will raise endless 
questions from people who look at the code.

> +		case PF_VECTOR:
> +			vcpu->arch.exception.nr = DF_VECTOR;
> +			vcpu->arch.exception.error_code = 0;
> +			return;
> +		default:
> +			/* replace previous exception with a new one in a hope
> +			   that instruction re-execution will regenerate lost
> +			   exception */
> +			vcpu->arch.exception.pending = false;
> +			break;
>  		}
> -		return;
>  	}

-- 
error compiling committee.c: too many arguments to function


      reply	other threads:[~2009-06-14 11:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-11  8:26 [PATCH] Replace pending exception by PF if it happens serially Gleb Natapov
2009-06-14 11:01 ` Avi Kivity [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A34D891.4080104@redhat.com \
    --to=avi@redhat.com \
    --cc=gleb@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox