From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Replace pending exception by PF if it happens serially. Date: Sun, 14 Jun 2009 14:01:37 +0300 Message-ID: <4A34D891.4080104@redhat.com> References: <20090611082611.GA18996@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx2.redhat.com ([66.187.237.31]:46875 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753240AbZFNLBg (ORCPT ); Sun, 14 Jun 2009 07:01:36 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n5EB1dJ7025817 for ; Sun, 14 Jun 2009 07:01:39 -0400 In-Reply-To: <20090611082611.GA18996@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Gleb Natapov wrote: > Replace previous exception with a new one in a hope that instruction > re-execution will regenerate lost exception. > > Applied, thanks. > + switch(vcpu->arch.exception.nr) { > + case DF_VECTOR: > /* triple fault -> shutdown */ > set_bit(KVM_REQ_TRIPLE_FAULT, &vcpu->requests); > Added a 'return' here. It will work without, but will raise endless questions from people who look at the code. > + case PF_VECTOR: > + vcpu->arch.exception.nr = DF_VECTOR; > + vcpu->arch.exception.error_code = 0; > + return; > + default: > + /* replace previous exception with a new one in a hope > + that instruction re-execution will regenerate lost > + exception */ > + vcpu->arch.exception.pending = false; > + break; > } > - return; > } -- error compiling committee.c: too many arguments to function