From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: qemu-kvm broken after ./configure --disable-kvm Date: Sun, 14 Jun 2009 14:31:52 +0300 Message-ID: <4A34DFA8.1060103@redhat.com> References: <4A30FBA3.1070404@us.ibm.com> <4A310C58.6050301@web.de> <4A34DB51.3050700@redhat.com> <4A34DE41.7070506@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Beth Kon , Glauber Costa , kvm To: Jan Kiszka Return-path: Received: from mx2.redhat.com ([66.187.237.31]:60481 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751815AbZFNLby (ORCPT ); Sun, 14 Jun 2009 07:31:54 -0400 In-Reply-To: <4A34DE41.7070506@web.de> Sender: kvm-owner@vger.kernel.org List-ID: Jan Kiszka wrote: >>>> Building latest git with ./configure --disable-kvm breaks with errors in >>>> pcspk.c >>>> >>>> >>> With latest git, things break much earlier in case your host does not >>> provide linux/kvm.h because libkvm-all.h includes it unconditionally. >>> >>> >>> >> But qemu-kvm carries linux/kvm.h, so this never happens? >> > > 1. qemu-kvm does not use its own headers when you specify --disble-kvm. > That's the technical reason for this bug. > Ah, okay. This should be fixed (by including the headers) as long as we continue to carry kvm.h. > 2. Upstream does not, and it's unclear if it ever will (if we push > recent headers into kvm-kmod, I think there is no urgent need > anymore). At least for code to-be-pushed upstream, we must not > rely in this anyway. Yes. Adding the headers to kvm-kmod.h is the right thing technically, but something tells me we'll get a lot of failures by people compiling first and installing later, rather than the sequence needed to make things work: compile and install kvm-kmod, compile and install qemu[-kvm]. Not all of the failures will be visible at compile time. -- error compiling committee.c: too many arguments to function