Re: [PATCH 3/3] kvm-s390: streamline memslot handling - rebased

[Avi Kivity <avi@redhat.com>]

Marcelo Tosatti wrote:
>   
>> (continued below)
>>     
>>> Anyway, yeah, the set request / wait mechanism you implement here is
>>> quite similar to the idea mentioned earlier that could be used for x86.
>>>
>>> Just get rid of this explicit KVM_REQ_MMU_RELOAD knowledge in
>>> arch-independent code please (if you want to see this merged).
>>>   
>>>       
>> I agree to lift the wait part to other archs later if needed, but as  
>> mentioned above I could move this to arch code to the cost of one arch  
>> hook more. But as also mentioned it doesn't really hurt. I agree that it  
>> does not need to be KVM_REQ_MMU_RELOAD specific, we could just  
>> walk/clear/wake all bits on that vcpu->requests variable.
>> Would that be generic enough in your opinion ?
>>     
>
> Don't know.
>
> Avi?
>   

I think I lost the thread here, but I'll try.  Isn't the wake part 
make_all_vcpus_request() in kvm_main.c?  The wait part could be moved to 
a similar generic function.

-- 
error compiling committee.c: too many arguments to function