From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: qemu-kvm broken after ./configure --disable-kvm Date: Sun, 14 Jun 2009 16:14:46 +0300 Message-ID: <4A34F7C6.8040304@redhat.com> References: <4A30FBA3.1070404@us.ibm.com> <4A310C58.6050301@web.de> <4A34DB51.3050700@redhat.com> <4A34DE41.7070506@web.de> <4A34DFA8.1060103@redhat.com> <4A34F15D.4000704@web.de> <4A34F3FF.7040605@redhat.com> <4A34F5F3.3090109@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Beth Kon , Glauber Costa , kvm To: Jan Kiszka Return-path: Received: from mx2.redhat.com ([66.187.237.31]:48700 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751593AbZFNNOr (ORCPT ); Sun, 14 Jun 2009 09:14:47 -0400 In-Reply-To: <4A34F5F3.3090109@web.de> Sender: kvm-owner@vger.kernel.org List-ID: Jan Kiszka wrote: >>> That could (and probably should - independent of in-tree headers) be >>> caught by making all KVM_CAPs mandatory, ie. check for the latest and >>> greatest ones during configure and drop all the #ifdefs from the code. >>> >>> >> Not with out-of-tree headers. qemu-kvm-0.10.x ought to build against >> Linux 2.6.27, kvm-kmod-2.6.30, and kvm-91. >> >> Making all KVM_CAPs mandatory only works if we carry the headers with qemu. >> > > If we continue to carry our own headers, the #ifdefs are pointless. Yes. > If > we don't, the configure checks should issue an overview on all the > features that will be missing and give a hint how to resolve this > (kvm-kmod...). > Some features are optional (and we try to make most features optional so as not to force users to upgrade). -- error compiling committee.c: too many arguments to function