From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities] Date: Mon, 15 Jun 2009 12:38:48 +0300 Message-ID: <4A3616A8.5020801@redhat.com> References: <20090610150129.GC28601@redhat.com> <200906101624.30659.paul@codesourcery.com> <20090610174301.GC7416@shareable.org> <20090610182227.GN28601@redhat.com> <20090610192702.GH7416@shareable.org> <1244796209.16425.20.camel@blaa> <4A326C7E.3020309@codemonkey.ws> <1244822007.30522.68.camel@blaa> <20090614093411.GA6959@redhat.com> <4A34C4C9.8030105@redhat.com> <20090614094754.GC6959@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Mark McLoughlin , Anthony Liguori , Jamie Lokier , Carsten Otte , kvm@vger.kernel.org, Glauber Costa , Rusty Russell , qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, Blue Swirl , Christian Borntraeger , Paul Brook To: "Michael S. Tsirkin" Return-path: Received: from mx2.redhat.com ([66.187.237.31]:43734 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750964AbZFOJk4 (ORCPT ); Mon, 15 Jun 2009 05:40:56 -0400 In-Reply-To: <20090614094754.GC6959@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 06/14/2009 12:47 PM, Michael S. Tsirkin wrote: > Michael S. Tsirkin wrote: >>> If we want to remove a device from under a running guest, you need >>> hotplug. So we can't just remove several lines from the config and hope >>> that it'll work simply because the PCI address is stable. >>> >>> >> Why not? >> > > E.g. configuration cycles address a specific bus/slot. > You need cooperation from guest if you want to move > a device. > By "remove several lines from the config" I understood the guest needs to be restarted. Of course if you don't restart the guest you need true hotplug. -- error compiling committee.c: too many arguments to function