public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH 1/6] env->kvm_cpu_state.init is always zero here.
Date: Mon, 15 Jun 2009 12:55:27 +0300	[thread overview]
Message-ID: <4A361A8F.8030205@redhat.com> (raw)
In-Reply-To: <1244976742-22926-1-git-send-email-gleb@redhat.com>

On 06/14/2009 01:52 PM, Gleb Natapov wrote:
> Signed-off-by: Gleb Natapov<gleb@redhat.com>
> ---
>   qemu-kvm.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/qemu-kvm.c b/qemu-kvm.c
> index 2aeb17c..ec911ef 100644
> --- a/qemu-kvm.c
> +++ b/qemu-kvm.c
> @@ -412,7 +412,7 @@ static int kvm_main_loop_cpu(CPUState *env)
>   	    if (env->kvm_cpu_state.sipi_needed)
>   	        update_regs_for_sipi(env);
>       }
> -	if (!env->halted&&  !env->kvm_cpu_state.init)
> +	if (!env->halted)
>   	    kvm_cpu_exec(env);
>   	env->exit_request = 0;
>           env->exception_index = EXCP_INTERRUPT;
>    

Are you sure?  Can't a reset reenable it?


-- 
error compiling committee.c: too many arguments to function


  parent reply	other threads:[~2009-06-15  9:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-14 10:52 [PATCH 1/6] env->kvm_cpu_state.init is always zero here Gleb Natapov
2009-06-14 10:52 ` [PATCH 2/6] Do not use env->halted to decide where halted state should be handled Gleb Natapov
2009-06-14 10:52 ` [PATCH 3/6] Call kvm_arch_load_regs() instead of kvm_load_registers() Gleb Natapov
2009-06-14 10:52 ` [PATCH 4/6] Handle vcpu init/sipi by calling a function on vcpu Gleb Natapov
2009-06-15 10:03   ` Avi Kivity
2009-06-15 10:11     ` Gleb Natapov
2009-06-15 10:14       ` Avi Kivity
2009-06-15 10:16         ` Gleb Natapov
2009-06-15 10:26           ` Avi Kivity
2009-06-14 10:52 ` [PATCH 5/6] Rename kvm_(load|save)_mpstate to kvm_arch_(load|save)_mpstate Gleb Natapov
2009-06-14 10:52 ` [PATCH 6/6] Retrieve mp state info in cpu_synchronize_state() Gleb Natapov
2009-06-15  9:55 ` Avi Kivity [this message]
2009-06-15  9:58   ` [PATCH 1/6] env->kvm_cpu_state.init is always zero here Gleb Natapov
2009-06-15 10:05     ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A361A8F.8030205@redhat.com \
    --to=avi@redhat.com \
    --cc=gleb@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox