Re: [KVM PATCH v2 0/2] irqfd: use POLLHUP notification for close()

Michael S. Tsirkin
2009-06-12T04:10:43Z

[ Resending with correct address for Davide. Pls don't reply
to the original one, you'll get bounces. ]

On Thu, Jun 04, 2009 at 08:48:02AM -0400, Gregory Haskins wrote:
> (Applies to kvm.git/master:25deed73)
>
> Please see the header for 2/2 for a description. This patch series has been
> fully tested and appears to be working correctly.
>
> [Review notes:
> *) Paul has looked at the SRCU design and, to my knowledge, didn't find
> any holes.
> *) Michael, Avi, and myself agree that while the removal of the DEASSIGN
> vector is not desirable, the fix on close() is more important in
> the short-term. We can always add DEASSIGN support again in the
> future with a CAP bit.
> ]

So, I've been thinking about this, and this approach has another
problem: it depends on pollhup on close which is AFAIK an
eventfd-specific feature. This will prevent us from supporting polling
other useful file types, such as sockets and pipes, down the road, with
this interface.

And there's DEASSIGN issue which is needed for migration and MSI vector
remapping.

I didn't realise these implications when I suggested deassign on close.
To me, it now looks like we are better off reverting this patch.
We can later add 'deassign on close' support with CAP bit after all :)

Avi, Gregory, what's your take?

--
MST