From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3
 03/13] qemu: add routines to manage PCI capabilities]
Date: Mon, 15 Jun 2009 10:20:21 -0500
Message-ID: <4A3666B5.2000104@codemonkey.ws>
References: <20090610150129.GC28601@redhat.com> <200906101624.30659.paul@codesourcery.com> <20090610174301.GC7416@shareable.org> <20090610182227.GN28601@redhat.com> <20090610192702.GH7416@shareable.org> <1244796209.16425.20.camel@blaa> <4A326B5C.5010501@codemonkey.ws> <1244821292.30522.56.camel@blaa> <4A327E4A.7010300@codemonkey.ws> <1244825303.26769.19.camel@blaa> <20090614095016.GA7560@redhat.com> <4A3617D4.5090405@redhat.com> <4A36424D.3080901@codemonkey.ws> <4A364698.1090402@redhat.com> <4A364A9B.9070001@codemonkey.ws> <4A364E32.4010808@redhat.com> <4A365078.5080209@codemonkey.ws> <4A36529D.4060200@redhat.com> <4A3663C6.3070801@codemonkey.ws> <4A3664A0.6080105@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	Mark McLoughlin <markmc@redhat.com>,
	Jamie Lokier <jamie@shareable.org>,
	Carsten Otte <cotte@de.ibm.com>, kvm@vger.kernel.org,
	Glauber Costa <glommer@redhat.com>,
	Rusty Russell <rusty@rustcorp.com.au>, qemu-devel@nongnu.org,
	virtualization@lists.linux-foundation.org,
	Blue Swirl <blauwirbel@gmail.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Paul Brook <paul@codesourcery.com>
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-qy0-f173.google.com ([209.85.221.173]:57333 "EHLO
	mail-qy0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756874AbZFOPUY (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 15 Jun 2009 11:20:24 -0400
Received: by qyk3 with SMTP id 3so378897qyk.33
        for <kvm@vger.kernel.org>; Mon, 15 Jun 2009 08:20:26 -0700 (PDT)
In-Reply-To: <4A3664A0.6080105@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Avi Kivity wrote:
> I would prefer explicit names (pci_addr, lun, etc.) but would be okay 
> with generic names too.

I think having a generic address has a lot of value in terms of code 
implementation.  Otherwise, the valid options for -drive become 
context-sensitive which is going to be annoying and error-prone.  Some 
sanity could be added by using addressing prefixes like addr=pci:00:01.0 
or addr=scsi:0.3 but I'll leave that up to whoever takes this on.

Regards,

Anthony Liguori