From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities] Date: Mon, 15 Jun 2009 18:26:33 +0300 Message-ID: <4A366829.7060700@redhat.com> References: <20090610150129.GC28601@redhat.com> <200906101624.30659.paul@codesourcery.com> <20090610174301.GC7416@shareable.org> <20090610182227.GN28601@redhat.com> <20090610192702.GH7416@shareable.org> <1244796209.16425.20.camel@blaa> <4A326B5C.5010501@codemonkey.ws> <1244821292.30522.56.camel@blaa> <4A327E4A.7010300@codemonkey.ws> <1244825303.26769.19.camel@blaa> <20090614095016.GA7560@redhat.com> <4A3617D4.5090405@redhat.com> <4A36424D.3080901@codemonkey.ws> <4A364698.1090402@redhat.com> <4A364A9B.9070001@codemonkey.ws> <4A364E32.4010808@redhat.com> <4A365078.5080209@codemonkey.ws> <4A36529D.4060200@redhat.com> <4A3663C6.3070801@codemonkey.ws> <4A3664A0.6080105@redhat.com> <4A3666B5.2000104@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Michael S. Tsirkin" , Mark McLoughlin , Jamie Lokier , Carsten Otte , kvm@vger.kernel.org, Glauber Costa , Rusty Russell , qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, Blue Swirl , Christian Borntraeger , Paul Brook To: Anthony Liguori Return-path: Received: from mx2.redhat.com ([66.187.237.31]:38660 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752570AbZFOP2u (ORCPT ); Mon, 15 Jun 2009 11:28:50 -0400 In-Reply-To: <4A3666B5.2000104@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: On 06/15/2009 06:20 PM, Anthony Liguori wrote: > Avi Kivity wrote: >> I would prefer explicit names (pci_addr, lun, etc.) but would be okay >> with generic names too. > > I think having a generic address has a lot of value in terms of code > implementation. Otherwise, the valid options for -drive become > context-sensitive which is going to be annoying and error-prone. Some > sanity could be added by using addressing prefixes like > addr=pci:00:01.0 or addr=scsi:0.3 but I'll leave that up to whoever > takes this on. The code problems are easily solved by adding another level of indirection. User confusion problems are only aggravated by additional abstraction, though ("what do I put in addr=, here?"). -- error compiling committee.c: too many arguments to function