public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] Activate Virtualization On Demand v2
Date: Thu, 18 Jun 2009 11:35:14 +0300	[thread overview]
Message-ID: <4A39FC42.8080708@redhat.com> (raw)
In-Reply-To: <203D0184-4361-4C42-BBFE-24106AF1472A@suse.de>

On 06/18/2009 12:56 AM, Alexander Graf wrote:
>> I can test suspend/resume for you if you don't have a friendly 
>> machine.  I have a personal interest in keeping it working :)
>
>
> Thinking about it again - there's only the atomic dec_and_test vs. 
> read thing and the suspend test missing.
>
> Is the atomic operation as is really that confusing? 

Yes.  It says, "something tricky is going on, see if you can find it".

> If not, we can keep the patch as is and you simply try s2ram on your 
> notebook :-). I'm pretty sure it works - it used to.

It looks like it will work, but these things are tricky.  I'll test an 
updated patch.  Please also test reboot on Intel with a VM spinning and 
with no VMs loaded - Intel reboots are tricky too.

-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2009-06-18  8:34 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-15 11:30 [PATCH] Activate Virtualization On Demand v2 Alexander Graf
2009-06-15 12:17 ` Christoph Hellwig
2009-06-15 12:25   ` Alexander Graf
2009-06-15 12:27     ` Christoph Hellwig
2009-06-16 14:02   ` Avi Kivity
2009-06-16 14:01 ` Avi Kivity
2009-06-16 14:08   ` Alexander Graf
2009-06-16 15:13     ` Avi Kivity
2009-06-17 21:56       ` Alexander Graf
2009-06-18  8:35         ` Avi Kivity [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-11-05  8:48 Alexander Graf
2008-11-05 10:06 ` Avi Kivity
2008-11-05 10:28   ` Alexander Graf
2008-11-05 10:45     ` Avi Kivity
2008-11-05 10:53       ` Alexander Graf
2008-11-05 11:23       ` Alexander Graf
2008-11-05 10:45 ` Zhang, Xiantao
2008-11-05 10:54   ` Alexander Graf
2008-11-05 10:58 ` Daniel P. Berrange
2008-11-05 11:01   ` Alexander Graf
2008-11-05 13:06 ` Christian Borntraeger
2008-11-05 13:12   ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A39FC42.8080708@redhat.com \
    --to=avi@redhat.com \
    --cc=agraf@suse.de \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox