From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Activate Virtualization On Demand v2 Date: Thu, 18 Jun 2009 11:35:14 +0300 Message-ID: <4A39FC42.8080708@redhat.com> References: <1245065405-5714-1-git-send-email-agraf@suse.de> <4A37A59D.5070604@redhat.com> <4A37A744.1050705@suse.de> <4A37B6AC.4020401@redhat.com> <203D0184-4361-4C42-BBFE-24106AF1472A@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Alexander Graf Return-path: Received: from mx2.redhat.com ([66.187.237.31]:54094 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752547AbZFRIew (ORCPT ); Thu, 18 Jun 2009 04:34:52 -0400 In-Reply-To: <203D0184-4361-4C42-BBFE-24106AF1472A@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: On 06/18/2009 12:56 AM, Alexander Graf wrote: >> I can test suspend/resume for you if you don't have a friendly >> machine. I have a personal interest in keeping it working :) > > > Thinking about it again - there's only the atomic dec_and_test vs. > read thing and the suspend test missing. > > Is the atomic operation as is really that confusing? Yes. It says, "something tricky is going on, see if you can find it". > If not, we can keep the patch as is and you simply try s2ram on your > notebook :-). I'm pretty sure it works - it used to. It looks like it will work, but these things are tricky. I'll test an updated patch. Please also test reboot on Intel with a VM spinning and with no VMs loaded - Intel reboots are tricky too. -- error compiling committee.c: too many arguments to function