From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [KVM PATCH v7 1/2] KVM: make io_bus interface more robust
Date: Thu, 18 Jun 2009 14:35:33 +0300
Message-ID: <4A3A2685.4060500@redhat.com>
References: <20090616133751.14362.12674.stgit@dev.haskins.net> <20090616134230.14362.39612.stgit@dev.haskins.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	davidel@xmailserver.org, mtosatti@redhat.com,
	paulmck@linux.vnet.ibm.com, markmc@redhat.com
To: Gregory Haskins <ghaskins@novell.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:38916 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754344AbZFRLfJ (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 18 Jun 2009 07:35:09 -0400
In-Reply-To: <20090616134230.14362.39612.stgit@dev.haskins.net>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 06/16/2009 04:42 PM, Gregory Haskins wrote:
> +
> +/* assumes kvm->lock held */
> +void kvm_io_bus_unregister_dev(struct kvm_io_bus *bus,
> +			       struct kvm_io_device *dev)
> +{
> +	int i;
> +
> +	for (i = 0; i<  bus->dev_count; i++) {
> +
> +		if (bus->devs[i] == dev) {
> +			int j;
> +
> +			/* backfill the hole */
> +			for (j = i; j<  bus->dev_count-1; j++)
> +				bus->devs[j] = bus->devs[j+1];
> +
> +			bus->dev_count--;
> +
> +			break;
>    

Could be simplified to

     if (bus->devs[i] == dev) {
         bus->devs[i] = bus->devs[--bus->dev_count];
         return;
     }

-- 
error compiling committee.c: too many arguments to function