From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: kvm-devel <kvm@vger.kernel.org>
Subject: Re: [PATCH v2] qemu-kvm: x86: Fix CPU initialization
Date: Sun, 21 Jun 2009 15:38:54 +0300 [thread overview]
Message-ID: <4A3E29DE.9060707@redhat.com> (raw)
In-Reply-To: <4A3BC837.3080102@siemens.com>
On 06/19/2009 08:17 PM, Jan Kiszka wrote:
> Jan Kiszka wrote:
>
>> Fix regression in CPU initialization caused by merge a5b526135d and try
>> to avoid this in the future by dropping qemu-kvm specific pc_new_cpu. If
>> such refactoring is desired, it should go through upstream first.
>>
>
> F...ine. I'll write a hundred times: "Don't post while still compiling."
> Here is a version that only fixes the regression.
>
Applied, thanks.
This has bitten us more than once. Care to upstream pc_new_cpu()?
we'll need it anyway when we upstream cpu hotplug, and this will make
life easier for us here downstream.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2009-06-21 12:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-19 15:01 -no-kvm broken since merge a5b526135d Jan Kiszka
2009-06-19 17:11 ` [PATCH] qemu-kvm: x86: Fix CPU initialization Jan Kiszka
2009-06-19 17:17 ` [PATCH v2] " Jan Kiszka
2009-06-21 12:38 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A3E29DE.9060707@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox