From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v2] qemu-kvm: x86: Fix CPU initialization Date: Sun, 21 Jun 2009 15:38:54 +0300 Message-ID: <4A3E29DE.9060707@redhat.com> References: <4A3BA861.6040601@siemens.com> <4A3BC6CB.402@siemens.com> <4A3BC837.3080102@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Jan Kiszka Return-path: Received: from mx2.redhat.com ([66.187.237.31]:58786 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750825AbZFUMiM (ORCPT ); Sun, 21 Jun 2009 08:38:12 -0400 In-Reply-To: <4A3BC837.3080102@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 06/19/2009 08:17 PM, Jan Kiszka wrote: > Jan Kiszka wrote: > >> Fix regression in CPU initialization caused by merge a5b526135d and try >> to avoid this in the future by dropping qemu-kvm specific pc_new_cpu. If >> such refactoring is desired, it should go through upstream first. >> > > F...ine. I'll write a hundred times: "Don't post while still compiling." > Here is a version that only fixes the regression. > Applied, thanks. This has bitten us more than once. Care to upstream pc_new_cpu()? we'll need it anyway when we upstream cpu hotplug, and this will make life easier for us here downstream. -- error compiling committee.c: too many arguments to function