From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH -tip]x86: kvm/x86_emulate.c toggle_interruptibility() should be static Date: Sun, 21 Jun 2009 15:46:47 +0300 Message-ID: <4A3E2BB7.2070008@redhat.com> References: <1245324205.7189.6.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Ingo Molnar , x86 maintainers , KVM list , LKML To: Jaswinder Singh Rajput Return-path: Received: from mx2.redhat.com ([66.187.237.31]:37246 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750997AbZFUMrU (ORCPT ); Sun, 21 Jun 2009 08:47:20 -0400 In-Reply-To: <1245324205.7189.6.camel@localhost.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On 06/18/2009 02:23 PM, Jaswinder Singh Rajput wrote: > toggle_interruptibility() is used only by same file, it should be static. > > Fixed following sparse warning : > > arch/x86/kvm/x86_emulate.c:1364:6: warning: symbol 'toggle_interruptibility' was not declared. Should it be static? > Applied, thanks. -- error compiling committee.c: too many arguments to function