From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 2/2][RFC] Kernel changes for HPET legacy mode (v7) Date: Mon, 22 Jun 2009 11:14:22 +0200 Message-ID: <4A3F4B6E.2050301@web.de> References: <1245329246-17526-1-git-send-email-eak@us.ibm.com> <1245329246-17526-3-git-send-email-eak@us.ibm.com> <4A3A8FC0.1000606@web.de> <4A3F4739.7070904@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig215FCFFE71B675531038D5BD" Cc: Beth Kon , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from fmmailgate02.web.de ([217.72.192.227]:56018 "EHLO fmmailgate02.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751660AbZFVJO2 (ORCPT ); Mon, 22 Jun 2009 05:14:28 -0400 In-Reply-To: <4A3F4739.7070904@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig215FCFFE71B675531038D5BD Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Avi Kivity wrote: > On 06/18/2009 10:04 PM, Jan Kiszka wrote: >> Hmm, stead of introducing a new pair of singe-purpose IOCTLs, why not >> add KVM_GET/SET_PIT2 which exchanges an extended kvm_pit_state2. And >> that struct should also include some flags field and enough padding to= >> be potentially extended yet again in the future. In that case I see no= >> problem having also a mode read-back interface. >> =20 >=20 > We'd only add kernel hpet if we were forced to (I imagine the same > applications/kernels that forced the PIT into the kernel will do the > same for HPET). >=20 Answer and citation does not yet correlate for me. Could you comment more explicitly if your are fine with Beth's proposed interface, rather prefer something like my suggestion or even want something totally different? Thanks, Jan --------------enig215FCFFE71B675531038D5BD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAko/S3MACgkQniDOoMHTA+m8tACfYa2h2NYOUJcga8VhR0v+wfM9 wnUAnjPXl30FzQOMhXfkcrXLNzq5qV5d =NasE -----END PGP SIGNATURE----- --------------enig215FCFFE71B675531038D5BD--