From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Huff Subject: Re: [KVM_AUTOTEST] unattended installs take 2 Date: Mon, 22 Jun 2009 09:13:42 -0400 Message-ID: <4A3F8386.5060709@redhat.com> References: <1245361860-26726-1-git-send-email-dhuff@redhat.com> <1245647403.2778.13.camel@freedom> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Michael Goldish To: Lucas Meneghel Rodrigues Return-path: Received: from mx2.redhat.com ([66.187.237.31]:36299 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752364AbZFVNNn (ORCPT ); Mon, 22 Jun 2009 09:13:43 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n5MDDkVW017195 for ; Mon, 22 Jun 2009 09:13:46 -0400 In-Reply-To: <1245647403.2778.13.camel@freedom> Sender: kvm-owner@vger.kernel.org List-ID: Lucas Meneghel Rodrigues wrote: > I've been trough the changes, thank you for your work David: > Comments/questions: > > * Any particular reason why you guys wrote the PXE boot setup as a > shell script instead of a python module (that could be also used as a > stand alone program)? We decided to use environmental scripts to set up any host specific prerequisite priour to execution any tests. This way there would be a standard/preferred way for tests to set up a specific environment on the host. I am including a snippet form a previous email explaining why we went down this path... Michael Goldish wrote: > The solution I had in mind was to add pre/post-processor parameters 'pre_command' and 'post_command' that represent shell commands to be executed before/after the test. A typical shell command would be one that runs an environment specific script that sets up mount points or whatever is needed for the test. This parameter would be provided for each test (in the config file) so one can 'variant' on it, to make different variants of the test (e.g. 'dbench' with local storage, and then with NFS storage, ...). There can also be pre/post-processing scripts for the entire job, that run before the first test and after the last one. > If you use a setup_ function you require the user to change kvm-autotest code in order to perform environment specific setup (and you also limit the user to python). I personally prefer to leave all environment specific stuff in external scripts outside the code, but I may be wrong. comments..... -D