From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [KVM PATCH v8 3/3] KVM: add iosignalfd support Date: Mon, 22 Jun 2009 17:30:18 +0300 Message-ID: <4A3F957A.6000501@redhat.com> References: <20090619002224.15859.97977.stgit@dev.haskins.net> <20090619003045.15859.73197.stgit@dev.haskins.net> <20090622104435.GA11594@redhat.com> <4A3F757C.6030508@novell.com> <20090622123022.GC12867@redhat.com> <4A3F8170.7000508@gmail.com> <20090622131351.GE12867@redhat.com> <4A3F84FD.3090700@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Michael S. Tsirkin" , Gregory Haskins , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, mtosatti@redhat.com, paulmck@linux.vnet.ibm.com, markmc@redhat.com To: Gregory Haskins Return-path: Received: from mx2.redhat.com ([66.187.237.31]:49929 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752319AbZFVO33 (ORCPT ); Mon, 22 Jun 2009 10:29:29 -0400 In-Reply-To: <4A3F84FD.3090700@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: On 06/22/2009 04:19 PM, Gregory Haskins wrote: > The question to ask is whether a guest can influence that condition. If > they can, its an attack vector to crash the host. I suspect they can't, > however. Therefore, your recommendation is perhaps a good approach so > this condition cannot ever go unnoticed. Avi? > No, this is host memory in the emulator context, allocated as unsigned long. But this is on x86 which isn't sensitive to alignment anyway. It's unlikely that other achitectures will supply unaligned pointers. We ought to convert the interface to pass a value anyway. -- error compiling committee.c: too many arguments to function