Re: [KVM PATCH v8 3/3] KVM: add iosignalfd support

[Gregory Haskins <ghaskins@novell.com>]

[-- Attachment #1: Type: text/plain, Size: 782 bytes --]

Avi Kivity wrote:
> On 06/22/2009 04:19 PM, Gregory Haskins wrote:
>> The question to ask is whether a guest can influence that condition.  If
>> they can, its an attack vector to crash the host.  I suspect they can't,
>> however.  Therefore, your recommendation is perhaps a good approach so
>> this condition cannot ever go unnoticed.  Avi?
>>    
>
> No, this is host memory in the emulator context, allocated as unsigned
> long.  But this is on x86 which isn't sensitive to alignment anyway.

Ok, will change to BUG_ON in v9

> It's unlikely that other achitectures will supply unaligned pointers.
>
Yeah, they shouldn't

> We ought to convert the interface to pass a value anyway.
>
Agreed.  As you said earlier, lets defer for now.

Thanks Avi,
-Greg


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 266 bytes --]