From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH RFC] pass write value to in_range pointers Date: Tue, 23 Jun 2009 12:54:14 +0300 Message-ID: <4A40A646.4010403@redhat.com> References: <20090619002224.15859.97977.stgit@dev.haskins.net> <20090619003045.15859.73197.stgit@dev.haskins.net> <20090622151631.GA14780@redhat.com> <4A3FA6FC.9030301@novell.com> <20090622160833.GA15228@redhat.com> <4A3FB156.3030301@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Michael S. Tsirkin" , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, mtosatti@redhat.com, paulmck@linux.vnet.ibm.com, markmc@redhat.com To: Gregory Haskins Return-path: Received: from mx2.redhat.com ([66.187.237.31]:38963 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756734AbZFWJxS (ORCPT ); Tue, 23 Jun 2009 05:53:18 -0400 In-Reply-To: <4A3FB156.3030301@novell.com> Sender: kvm-owner@vger.kernel.org List-ID: On 06/22/2009 07:29 PM, Gregory Haskins wrote: >> We actually already have aliasing: is_write flag is used for this >> purpose. >> > > Yes, but read/write address aliasing is not the same thing is > multi-match data aliasing. Besides, your proposal also breaks some of > the natural relationship models (e.g. all the aliased iosignal_items > always belong to the same underlying device. io_bus entries have an > arbitrary topology). > It's all one big hack, we want to get the correct function called with as little fuss as possible. -- error compiling committee.c: too many arguments to function