From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/2] allow hypervisor CPUID bit to be overriden Date: Tue, 23 Jun 2009 13:01:16 +0300 Message-ID: <4A40A7EC.8070100@redhat.com> References: <1245707244-743-1-git-send-email-andre.przywara@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, kvm@vger.kernel.org To: Andre Przywara Return-path: Received: from mx2.redhat.com ([66.187.237.31]:46936 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752103AbZFWKAW (ORCPT ); Tue, 23 Jun 2009 06:00:22 -0400 In-Reply-To: <1245707244-743-1-git-send-email-andre.przywara@amd.com> Sender: kvm-owner@vger.kernel.org List-ID: On 06/23/2009 12:47 AM, Andre Przywara wrote: > KVM defaults to the hypervisor CPUID bit to be set, whereas pure QEMU clears > it. On some occasions one want to set or clear it the other way round (for > instance to get HyperV running inside a guest). > Allow the default to be overridden on the command line and fix some > whitespace damage on the way. > It makes sense for qemu to set the hypervisor bit unconditionally. A guest running under qemu is not bare metal. That's a separate change though. Patch looks good. -- error compiling committee.c: too many arguments to function