From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory Haskins Subject: Re: [KVM PATCH v8 3/3] KVM: add iosignalfd support Date: Tue, 23 Jun 2009 07:40:32 -0400 Message-ID: <4A40BF30.9000707@novell.com> References: <20090619002224.15859.97977.stgit@dev.haskins.net> <20090619003045.15859.73197.stgit@dev.haskins.net> <20090623085633.GA16294@redhat.com> <4A40BD73.8050902@novell.com> <20090623113634.GC17635@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig3430ADB1817DC0835808E89A" Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, avi@redhat.com, mtosatti@redhat.com, paulmck@linux.vnet.ibm.com, markmc@redhat.com To: "Michael S. Tsirkin" Return-path: Received: from victor.provo.novell.com ([137.65.250.26]:45424 "EHLO victor.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751642AbZFWLkl (ORCPT ); Tue, 23 Jun 2009 07:40:41 -0400 In-Reply-To: <20090623113634.GC17635@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig3430ADB1817DC0835808E89A Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Michael S. Tsirkin wrote: > On Tue, Jun 23, 2009 at 07:33:07AM -0400, Gregory Haskins wrote: > =20 >> Michael S. Tsirkin wrote: >> =20 >>> On Thu, Jun 18, 2009 at 08:30:46PM -0400, Gregory Haskins wrote: >>> =20 >>> =20 >>>> +static int >>>> +iosignalfd_group_in_range(struct kvm_io_device *this, gpa_t addr, i= nt len, >>>> + int is_write) >>>> +{ >>>> + struct _iosignalfd_group *p =3D to_group(this); >>>> + >>>> + return ((addr >=3D p->addr && (addr < p->addr + p->length))); >>>> +} >>>> =20 >>>> =20 >>> I think I see a problem here. For virtio, we do not necessarily want = all >>> virtqueues for a device to live in kernel: there might be control >>> virtqueues that we want to leave in userspace. Since this claims all >>> writes to a specific address, the signal never makes it to userspace.= >>> >>> =20 >>> =20 >> You can use a wildcard. Would that work? >> >> =20 > > Nope, you need to know the value written. > > =20 Note: You can also terminate an eventfd in userspace...it doesn't have to terminate in-kernel. Not sure if that helps. --------------enig3430ADB1817DC0835808E89A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.11 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkpAvzEACgkQlOSOBdgZUxkyxwCeMoRc9C4FICoeF1VVIKTQkv23 eQ0Anj2TLvIOb6rnHOqZSyYYpnFDxce1 =wL0C -----END PGP SIGNATURE----- --------------enig3430ADB1817DC0835808E89A--