From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH RFC] pass write value to in_range pointers Date: Tue, 23 Jun 2009 14:56:23 +0300 Message-ID: <4A40C2E7.9000705@redhat.com> References: <20090619002224.15859.97977.stgit@dev.haskins.net> <20090619003045.15859.73197.stgit@dev.haskins.net> <20090622151631.GA14780@redhat.com> <4A3FA6FC.9030301@novell.com> <20090622160833.GA15228@redhat.com> <4A3FB156.3030301@novell.com> <20090622172720.GC15228@redhat.com> <4A405436.1080100@gmail.com> <20090623114438.GD17635@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Gregory Haskins , Gregory Haskins , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, mtosatti@redhat.com, paulmck@linux.vnet.ibm.com, markmc@redhat.com To: "Michael S. Tsirkin" Return-path: Received: from mx2.redhat.com ([66.187.237.31]:44162 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757628AbZFWLz3 (ORCPT ); Tue, 23 Jun 2009 07:55:29 -0400 In-Reply-To: <20090623114438.GD17635@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 06/23/2009 02:44 PM, Michael S. Tsirkin wrote: > On Tue, Jun 23, 2009 at 12:04:06AM -0400, Gregory Haskins wrote: > >>>> It will also need to support >>>> multiple matches. >>>> >>>> >>> What, signal many fds on the same address/value pair? >>> I see this as a bug. Why is this a good thing to support? >>> Just increases the chance of leaking this fd. >>> >>> >> I believe Avi asked for this feature specifically, so I will defer to him. >> > > Hmm. That's hard to implement in my model. Avi, can we give up > this feature? I don't think anyone needs this specifically ... > I think we can make do with passing that single eventfd to multiple consumers. It means their event count reads may return zero, but I guess we can live with that. I do want to retain flexibility in how we route events. -- error compiling committee.c: too many arguments to function