From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 4/4] dont trim the guest's hypervisor CPUID bit in KVM if the guest requests it Date: Wed, 24 Jun 2009 14:28:20 +0300 Message-ID: <4A420DD4.4020905@redhat.com> References: <1245840276-12702-1-git-send-email-andre.przywara@amd.com> <1245840276-12702-2-git-send-email-andre.przywara@amd.com> <1245840276-12702-3-git-send-email-andre.przywara@amd.com> <1245840276-12702-4-git-send-email-andre.przywara@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Andre Przywara Return-path: Received: from mx2.redhat.com ([66.187.237.31]:36920 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751560AbZFXL1T (ORCPT ); Wed, 24 Jun 2009 07:27:19 -0400 In-Reply-To: <1245840276-12702-4-git-send-email-andre.przywara@amd.com> Sender: kvm-owner@vger.kernel.org List-ID: On 06/24/2009 01:44 PM, Andre Przywara wrote: > Signed-off-by: Andre Przywara > --- > arch/x86/kvm/x86.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index e6e61ee..6ad0f93 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -1415,7 +1415,7 @@ static void do_cpuid_ent(struct kvm_cpuid_entry2 *entry, u32 function, > 0 /* Reserved */ | F(CX16) | 0 /* xTPR Update, PDCM */ | > 0 /* Reserved, DCA */ | F(XMM4_1) | > F(XMM4_2) | 0 /* x2APIC */ | F(MOVBE) | F(POPCNT) | > - 0 /* Reserved, XSAVE, OSXSAVE */; > + 0 /* Reserved, XSAVE, OSXSAVE */ | F(HYPERVISOR); > I think this should be handled in qemu, since it isn't really a cpu bit. -- error compiling committee.c: too many arguments to function