From mboxrd@z Thu Jan 1 00:00:00 1970 From: jason wang Subject: Re: Latest kvm autotest patch queue Date: Thu, 25 Jun 2009 21:02:02 +0800 Message-ID: <4A43754A.9060201@redhat.com> References: <1245677063.2778.30.camel@freedom> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Lucas Meneghel Rodrigues , KVM mailing list , Autotest mailing list , Michael Goldish To: sudhir kumar Return-path: Received: from mx2.redhat.com ([66.187.237.31]:58063 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751861AbZFYNBl (ORCPT ); Thu, 25 Jun 2009 09:01:41 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: sudhir kumar =E5=86=99=E9=81=93: > On Mon, Jun 22, 2009 at 6:54 PM, Lucas Meneghel Rodrigues wrote: > =20 >> KVM Autotest patch queue >> >> --------------------------------------------------------------------= ------------ >> Michael Goldish (mgoldish@redhat.com) >> >> 1) KVM test: optionally convert PPM files to PNG format after test -= Reviewed >> >> 2) Step file tests: introducing a new feature and some small changes= - Reviewed >> >> 3) Introducing kvm_subprocess - Reviewed >> >> --------------------------------------------------------------------= ------------ >> Jason Wang (jasowang@redhat.com) >> >> 1) TAP network support in kvm-autotest >> >> Michael Goldish has a similar patch to this one, so we need to decid= e which one >> =20 > I remember Michael's patch using nmap to get the ip of the guest. I > tested the patch and found nmap taking too long to do a lookup and ge= t > the guest ip. I will suggets two things here. > 1. Modify nmap options to make nmap lookup really faster. > 2. Provide an option to use a dictionary based(mac address to ip > mapping) lookup in config file and return mapped ip for a mac address= =2E > > I can send a patch for option 2 on top of Michael's patch. In the > simplest form it will generate a dictionary from a macaddress vs IP > address list(provided by the dhcp server in your lab/environment. you > can put this list in a file and use it). You need to specify macaddr > parameter in config file from this list. Looking the mac address the > parser will return the corresponding ip address from the dictionary > generated. > > Please let me know if 2 sounds good. Also I think I missed to look at > Jason's patch? > =20 My patch could be seen at http://patchwork.kernel.org/patch/23524/. I=20 think the mac:ip dictionary is not flexible enough especially in a=20 network with public dhcp server. The scanning method could be used in=20 either public or private bridge. But my patch still have some problems=20 to solve and need advices: 1 Mac address generation: I could rework the patch and make it could=20 accept user specified address range, but the user should guarantee its=20 validity. 2 IP scanner: Is there any option of nmap could make the scanning faste= r=20 than -sP? I also agree that nmap is not a elegant method, but it seems=20 the sole choice ( or write a simple scanner through python?) . Another=20 method is to snoop the dhcp session through tcpdump during the=20 vm.create() but this method does not feed for all dhcp server. 3 I want the make network method to be an exclusive options and want to= =20 know if it is useful to have both user mode nics and bridge nics=20 simultaneously. 4 Based on advices of Michael Goldish I would add an index to=20 get_address() and get_port() to adapt the environments with multiple ni= cs. I would rework the patches based on the comments, and like to see the=20 patch of michael. Thanks. **