Re: [KVM PATCH v8 1/3] KVM: make io_bus interface more robust

Gregory Haskins
2009-06-25T14:56:41Z

[-- Attachment #1: Type: text/plain, Size: 933 bytes --]

Michael S. Tsirkin wrote:
> On Thu, Jun 25, 2009 at 10:22:29AM -0400, Gregory Haskins wrote:
>
>> Gregory Haskins wrote:
>>
>>> Today kvm_io_bus_regsiter_dev() returns void and will internally BUG_ON if it
>>> fails. We want to create dynamic MMIO/PIO entries driven from userspace later
>>> in the series, so we need to enhance the code to be more robust with the
>>> following changes:
>>>
>>> 1) Add a return value to the registration function
>>> 2) Fix up all the callsites to check the return code, handle any
>>> failures, and percolate the error up to the caller.
>>> 3) Add an unregister function that collapses holes in the array
>>>
>
> Does not unregister need rcu bus fixes to work?
>
>
Not without users ;)

But, hmm. Perhaps I should re-split out the return value stuff so it
can go independent of the unregister. Gah, this io_bus is a nightmare.

-Greg

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 266 bytes --]