From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [PATCHv6 05/12] qemu/pci: MSI-X support functions
Date: Fri, 26 Jun 2009 11:01:12 -0500
Message-ID: <4A44F0C8.8020807@codemonkey.ws>
References: <cover.1245594586.git.mst@redhat.com> <20090621164954.GF10164@redhat.com> <20090626142635.GD5939@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Paul Brook <paul@codesourcery.com>, Avi Kivity <avi@redhat.com>,
	qemu-devel@nongnu.org, Carsten Otte <cotte@de.ibm.com>,
	kvm@vger.kernel.org, Rusty Russell <rusty@rustcorp.com.au>,
	virtualization@lists.linux-foundation.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Blue Swirl <blauwirbel@gmail.com>,
	Glauber Costa <glommer@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from rv-out-0506.google.com ([209.85.198.232]:23776 "EHLO
	rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750964AbZFZQBQ (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 26 Jun 2009 12:01:16 -0400
Received: by rv-out-0506.google.com with SMTP id f6so653832rvb.1
        for <kvm@vger.kernel.org>; Fri, 26 Jun 2009 09:01:18 -0700 (PDT)
In-Reply-To: <20090626142635.GD5939@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Michael S. Tsirkin wrote:
> On Sun, Jun 21, 2009 at 07:49:54PM +0300, Michael S. Tsirkin wrote:
>   
>> +    dev->msix_mmio_index = cpu_register_io_memory(0, msix_mmio_read,
>> +                                                  msix_mmio_write, dev);
>>     
>
>
> The signature for cpu_register_io_memory changed meanwhile so this now
> needs to be:
>
> +    dev->msix_mmio_index = cpu_register_io_memory(msix_mmio_read,
> +                                                  msix_mmio_write, dev);
>
> Anthony, I guess you figured this out, or do you want me to respin the series
> with this minor fix?
>   

It's already changed in staging.

Regards,

Anthony Liguori