From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Add kvm_set_boot_cpu_id() API. Date: Sun, 28 Jun 2009 12:29:26 +0300 Message-ID: <4A4737F6.3050607@redhat.com> References: <1245932460-15616-3-git-send-email-gleb@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx2.redhat.com ([66.187.237.31]:44795 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752084AbZF1J16 (ORCPT ); Sun, 28 Jun 2009 05:27:58 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n5S9S1e5008395 for ; Sun, 28 Jun 2009 05:28:01 -0400 In-Reply-To: <1245932460-15616-3-git-send-email-gleb@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 06/25/2009 03:21 PM, Gleb Natapov wrote: > Signed-off-by: Gleb Natapov > Why is it needed? (good changelog material). > } > - > + > + kvm_set_boot_cpu_id(0); > You're not testing for failure. Doesn't matter here because it's the default, but then you can omit the call entirely. -- error compiling committee.c: too many arguments to function