From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] Add kvm_set_boot_cpu_id() API.
Date: Sun, 28 Jun 2009 13:31:28 +0300 [thread overview]
Message-ID: <4A474680.4010602@redhat.com> (raw)
In-Reply-To: <20090628093313.GM20289@redhat.com>
On 06/28/2009 12:33 PM, Gleb Natapov wrote:
> On Sun, Jun 28, 2009 at 12:29:26PM +0300, Avi Kivity wrote:
>
>> On 06/25/2009 03:21 PM, Gleb Natapov wrote:
>>
>>> Signed-off-by: Gleb Natapov<gleb@redhat.com>
>>>
>>>
>> Why is it needed? (good changelog material).
>>
>>
> OK.
>
>
Well, why?
>>> }
>>> -
>>> +
>>> + kvm_set_boot_cpu_id(0);
>>>
>>>
>> You're not testing for failure. Doesn't matter here because it's the
>> default, but then you can omit the call entirely.
>>
>>
> This is a place holder. The patch adds an interface but doesn't add any
> user if this line is omitted. As you said there is no need to check for
> failure in this case, if we do we will not be able to run on older
> kernels.
>
It's also good to call the new API as a way of exercising it.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-06-28 10:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-25 12:21 [PATCH] Add kvm_set_boot_cpu_id() API Gleb Natapov
2009-06-28 9:29 ` Avi Kivity
2009-06-28 9:33 ` Gleb Natapov
2009-06-28 10:31 ` Avi Kivity [this message]
2009-06-28 12:25 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A474680.4010602@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox