public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Yu Zhao <yu.zhao@intel.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"jbarnes@virtuousgeek.org" <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH v5 6/6] VT-d: support the device IOTLB
Date: Mon, 29 Jun 2009 11:07:21 +0800	[thread overview]
Message-ID: <4A482FE9.5090503@intel.com> (raw)
In-Reply-To: <1246199317.663.578.camel@macbook.infradead.org>

David Woodhouse wrote:
> On Mon, 2009-05-18 at 13:51 +0800, Yu Zhao wrote:
>> @@ -965,6 +1037,8 @@ static void iommu_flush_iotlb_psi(struct intel_iommu *iommu, u16 did,
>>         else
>>                 iommu->flush.flush_iotlb(iommu, did, addr, mask,
>>                                                 DMA_TLB_PSI_FLUSH);
>> +       if (did)
>> +               iommu_flush_dev_iotlb(iommu->domains[did], addr, mask);
>>  }
>>  
>>  static void iommu_disable_protect_mem_regions(struct intel_iommu *iommu)
> 
> Hm, why 'if (did)' ? 
> 
> Domain ID zero is only special in caching mode. Should it be:
> 	if (!cap_caching_mode(iommu->cap) || did)
> ?

Yes, you are right. Domain ID 0 is only reserved for caching mode. Will 
send a fix for this.

Thanks!

  reply	other threads:[~2009-06-29  3:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-18  5:51 [PATCH v5 0/6] ATS capability support for Intel IOMMU Yu Zhao
2009-05-18  5:51 ` [PATCH v5 1/6] PCI: support the ATS capability Yu Zhao
2009-05-18  5:51 ` [PATCH v5 2/6] PCI: handle Virtual Function ATS enabling Yu Zhao
2009-05-18  5:51 ` [PATCH v5 3/6] VT-d: parse ATSR in DMA Remapping Reporting Structure Yu Zhao
2009-05-18  5:51 ` [PATCH v5 4/6] VT-d: add device IOTLB invalidation support Yu Zhao
2009-05-18  5:51 ` [PATCH v5 5/6] VT-d: cleanup iommu_flush_iotlb_psi and flush_unmaps Yu Zhao
2009-05-18  5:51 ` [PATCH v5 6/6] VT-d: support the device IOTLB Yu Zhao
2009-06-28 14:28   ` David Woodhouse
2009-06-29  3:07     ` Yu Zhao [this message]
2009-08-09  9:33   ` David Woodhouse
2009-08-09 10:28   ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A482FE9.5090503@intel.com \
    --to=yu.zhao@intel.com \
    --cc=dwmw2@infradead.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jbarnes@virtuousgeek.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox