From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/3 v2] Add Directed EOI support to APIC emulation Date: Mon, 29 Jun 2009 13:01:17 +0300 Message-ID: <4A4890ED.9050904@redhat.com> References: <1246191331-31085-1-git-send-email-gleb@redhat.com> <1246191331-31085-2-git-send-email-gleb@redhat.com> <4A4886E4.3070907@redhat.com> <20090629092937.GT20289@redhat.com> <4A488E0C.7080207@redhat.com> <20090629095228.GV20289@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx2.redhat.com ([66.187.237.31]:56492 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751201AbZF2J7p (ORCPT ); Mon, 29 Jun 2009 05:59:45 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n5T9xnkQ027468 for ; Mon, 29 Jun 2009 05:59:49 -0400 In-Reply-To: <20090629095228.GV20289@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 06/29/2009 12:52 PM, Gleb Natapov wrote: >> We're changing something that the guests sees. Suppose the guest has a >> bug in directed EOI, just upgrading kvm will cause it to trigger. If we >> make it dependent on x2apic (or something else that needs to be selected >> by the user), we maintain compatibility. >> >> > Yes, I thought about something else (not x2apic). But yet another command line > switch look like overkill. > It is. So enabling on x2apic avoids the compatibility issue and avoids adding another useless control. -- error compiling committee.c: too many arguments to function