From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: Problems on AMD laptops Date: Mon, 29 Jun 2009 17:54:46 +0300 Message-ID: <4A48D5B6.9040607@redhat.com> References: <4A48C47D.3070908@redhat.com> <20090629143915.GG4182@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: KVM list To: Joerg Roedel Return-path: Received: from mx2.redhat.com ([66.187.237.31]:34713 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751226AbZF2OxN (ORCPT ); Mon, 29 Jun 2009 10:53:13 -0400 In-Reply-To: <20090629143915.GG4182@8bytes.org> Sender: kvm-owner@vger.kernel.org List-ID: On 06/29/2009 05:39 PM, Joerg Roedel wrote: > On Mon, Jun 29, 2009 at 04:41:17PM +0300, Avi Kivity wrote: > >> kerneloops.org shows tons of oopses on amd, see >> http://www.kerneloops.org/oops.php?number=79008. I suspect this has to >> do with resuming a laptop while a guest is running. Can anyone confirm >> or deny? >> > > I havn't verified this yet but it may have to do with dirty caches that > are not written back to memory in suspend-to-ram and are thus lost. Wouldn't that kill resume generally, not just kvm on amd? > The > resume code-path looks otherwise sane to me. The only thing I can > imagine is that a bit in the cpu_hardware_enabled cpumask is wrong after > resume. > I saw some of these oopses on cpu 0, which had better be plugged in. > Btw. it is guaranteed that with cpu-hotplug the cpu isn't already > executing processes when the CPU_ONLINE event call chain is called? > At least the CPU is marked online and active at that point in time. > Yes: static struct notifier_block kvm_cpu_notifier = { .notifier_call = kvm_cpu_hotplug, .priority = 20, /* must be > scheduler priority */ }; One thing I think is missing is a call to svm_cpu_init() on real hotplug. -- error compiling committee.c: too many arguments to function