From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH] Warn if a qcow (not qcow2) file is opened Date: Tue, 30 Jun 2009 11:42:45 -0500 Message-ID: <4A4A4085.9020601@codemonkey.ws> References: <1246284289-25394-1-git-send-email-avi@redhat.com> <4A4A13F7.8050904@codemonkey.ws> <4A4A19B7.3070600@redhat.com> <200906301521.26152.paul@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Kevin Wolf , qemu-devel@nongnu.org, kvm@vger.kernel.org, Avi Kivity To: Paul Brook Return-path: In-Reply-To: <200906301521.26152.paul@codesourcery.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org Paul Brook wrote: > IMHO there's little value in just printing a warning. Until it actually goes > away, people are liable to assume we're just being paranoid/awkward and keep > using it anyway. > > I suggest crippling it now and, assuming noone steps up to fix+maintain it, > ripping out the write support altogether at next release. > I'm assuming the readonly code is in better shape, and can be supported with > relatively little effort. > Yes, that's what I was getting at. We need to support read-only in order to allow people to convert to qcow2. If we're sufficiently concerned that there is data corruption in the write path, we should disable it to keep a user from shooting themselves in the foot. Regards, Anthony Liguori > Paul >