From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: target-i386/kvm.c vs. qemu-kvm-x86.c Date: Thu, 02 Jul 2009 13:13:24 +0300 Message-ID: <4A4C8844.4070209@redhat.com> References: <4A4C8686.4020908@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org To: Andre Przywara Return-path: Received: from mx2.redhat.com ([66.187.237.31]:57521 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753118AbZGBKLc (ORCPT ); Thu, 2 Jul 2009 06:11:32 -0400 In-Reply-To: <4A4C8686.4020908@amd.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/02/2009 01:05 PM, Andre Przywara wrote: > Hi, > > the lastest qemu -> qemu-kvm sync pulled the kvm_trim_features() > function from QEMU's target-i386/kvm.c into the qemu-kvm tree, where > it is already defined in qemu-kvm-x86.c (which does not exist in > qemu.git). > AFAICS qemu-kvm only uses the last file, so the target-i386 code is > not triggered. > What is the future of these two files? Will one vanish? Will they be > merged? Where to put new features in? All of the above. The goal is to merge the features of qemu-kvm.c and qemu-kvm-x86.c into kvm-all.c and kvm.c, eventually removing the former. In general new features need to be added in both. -- error compiling committee.c: too many arguments to function