* [PATCH] qemu-kvm: fix typo in configure
@ 2009-07-01 11:27 Michael S. Tsirkin
2009-07-01 23:07 ` Dustin Kirkland
2009-07-02 11:22 ` Avi Kivity
0 siblings, 2 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2009-07-01 11:27 UTC (permalink / raw)
To: avi, kvm
Kill extra \). Also escape ! for clarity and bourne shell
compatibility.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
This patch fixes configure on next for me
configure | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/configure b/configure
index f76f511..b62e3d7 100755
--- a/configure
+++ b/configure
@@ -2141,10 +2141,10 @@ configure_kvm() {
}
# Make sure the target and host cpus are compatible
-if test ! \( "$target_cpu" = "$cpu" -o \
+if test \! \( "$target_cpu" = "$cpu" -o \
\( "$target_cpu" = "ppcemb" -a "$cpu" = "ppc" \) -o \
- \( "$target_cpu" = "x86_64" -a "$cpu" = "i386" \) -o \
- \( "$target_cpu" = "i386" -a "$cpu" = "x86_64" \) \) -o \
+ \( "$target_cpu" = "x86_64" -a "$cpu" = "i386" \) -o \
+ \( "$target_cpu" = "i386" -a "$cpu" = "x86_64" \) -o \
\( "$target_cpu" = "ia64" -a "$cpu" = "ia64" \) \) ; then
target_kvm="no"
fi
--
1.6.2.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] qemu-kvm: fix typo in configure
2009-07-01 11:27 [PATCH] qemu-kvm: fix typo in configure Michael S. Tsirkin
@ 2009-07-01 23:07 ` Dustin Kirkland
2009-07-02 11:22 ` Avi Kivity
1 sibling, 0 replies; 3+ messages in thread
From: Dustin Kirkland @ 2009-07-01 23:07 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: avi, kvm
On Wed, Jul 1, 2009 at 4:27 AM, Michael S. Tsirkin<mst@redhat.com> wrote:
> Kill extra \). Also escape ! for clarity and bourne shell
> compatibility.
Agreed. Looks like this one was introduced during the last merge from
qemu. It bit me too.
:-Dustin
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>
> This patch fixes configure on next for me
>
> configure | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/configure b/configure
> index f76f511..b62e3d7 100755
> --- a/configure
> +++ b/configure
> @@ -2141,10 +2141,10 @@ configure_kvm() {
> }
>
> # Make sure the target and host cpus are compatible
> -if test ! \( "$target_cpu" = "$cpu" -o \
> +if test \! \( "$target_cpu" = "$cpu" -o \
> \( "$target_cpu" = "ppcemb" -a "$cpu" = "ppc" \) -o \
> - \( "$target_cpu" = "x86_64" -a "$cpu" = "i386" \) -o \
> - \( "$target_cpu" = "i386" -a "$cpu" = "x86_64" \) \) -o \
> + \( "$target_cpu" = "x86_64" -a "$cpu" = "i386" \) -o \
> + \( "$target_cpu" = "i386" -a "$cpu" = "x86_64" \) -o \
> \( "$target_cpu" = "ia64" -a "$cpu" = "ia64" \) \) ; then
> target_kvm="no"
> fi
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] qemu-kvm: fix typo in configure
2009-07-01 11:27 [PATCH] qemu-kvm: fix typo in configure Michael S. Tsirkin
2009-07-01 23:07 ` Dustin Kirkland
@ 2009-07-02 11:22 ` Avi Kivity
1 sibling, 0 replies; 3+ messages in thread
From: Avi Kivity @ 2009-07-02 11:22 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: kvm
On 07/01/2009 02:27 PM, Michael S. Tsirkin wrote:
> Kill extra \). Also escape ! for clarity and bourne shell
> compatibility.
>
>
I applied a similar fix from Jan.
>
> # Make sure the target and host cpus are compatible
> -if test ! \( "$target_cpu" = "$cpu" -o \
> +if test \! \( "$target_cpu" = "$cpu" -o \
>
This is needed in qemu.git, in several places.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-07-02 11:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-01 11:27 [PATCH] qemu-kvm: fix typo in configure Michael S. Tsirkin
2009-07-01 23:07 ` Dustin Kirkland
2009-07-02 11:22 ` Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox