From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory Haskins Subject: Re: [KVM PATCH v8 1/3] KVM: Fix races in irqfd using new eventfd_kref_get interface Date: Thu, 02 Jul 2009 10:27:00 -0400 Message-ID: <4A4CC3B4.7060109@novell.com> References: <20090701160208.3615.99153.stgit@dev.haskins.net> <20090701160902.3615.39426.stgit@dev.haskins.net> <4A4CC14C.1000905@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig2AFF6DD0EBB5DAEE97715E8D" Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, mst@redhat.com, davidel@xmailserver.org To: Avi Kivity Return-path: Received: from victor.provo.novell.com ([137.65.250.26]:43637 "EHLO victor.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753302AbZGBO1Q (ORCPT ); Thu, 2 Jul 2009 10:27:16 -0400 In-Reply-To: <4A4CC14C.1000905@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig2AFF6DD0EBB5DAEE97715E8D Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Avi Kivity wrote: > On 07/01/2009 07:09 PM, Gregory Haskins wrote: >> eventfd currently emits a POLLHUP wakeup on f_ops->release() to >> generate a >> "release" callback. This lets eventfd clients know if the eventfd is >> about >> to go away and is very useful particularly for in-kernel clients.=20 >> However, >> until recently it is not possible to use this feature of eventfd in a >> race-free way. >> >> This patch utilizes a new eventfd interface to rectify the problem.=20 >> It also >> converts the eventfd POLLHUP generation code to use the locked variant= >> of wakeup. >> >> Signed-off-by: Gregory Haskins >> CC: Davide Libenzi >> --- >> >> fs/eventfd.c | 7 -- >> include/linux/kvm_host.h | 5 + >> virt/kvm/eventfd.c | 187 >> ++++++++++++++++++++++++++++++++-------------- >> 3 files changed, 134 insertions(+), 65 deletions(-) >> =20 > > > Please split the eventfd.c hunk into a separate patch. When preparing > the 2.6.32 submission, I'll fold that into the patch into its > antipatch and they'll disappear. > Ok, but note that that means I should probably split 1/3 back out into 1/5 (prepare), 2/5 (eventfd hunk), 3/5 (fix irqfd) again like I had in v7 so that the series is bisectable. Is that ok? -Greg --------------enig2AFF6DD0EBB5DAEE97715E8D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.11 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkpMw7gACgkQlOSOBdgZUxnjsgCghbwatTjbiCf1sOLuGha3PZrV Z90AoIr6vqtbpgxLk9IbzoCA60j5IhdF =zevp -----END PGP SIGNATURE----- --------------enig2AFF6DD0EBB5DAEE97715E8D--