From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yolkfull Chow Subject: Re: [Autotest] [PATCH] Add a client-side test qemu_iotests Date: Fri, 03 Jul 2009 13:11:16 +0800 Message-ID: <4A4D92F4.2060204@redhat.com> References: <1246505385-8398-1-git-send-email-yzhou@redhat.com> <4A4C3BB5.8040003@redhat.com> <4A4C414E.6000806@redhat.com> <1246580603.6508.25.camel@localhost.localdomain> <1246597431.3378.11.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: autotest@test.kernel.org, kvm@vger.kernel.org To: Lucas Meneghel Rodrigues Return-path: Received: from mx2.redhat.com ([66.187.237.31]:51164 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751627AbZGCFLQ (ORCPT ); Fri, 3 Jul 2009 01:11:16 -0400 In-Reply-To: <1246597431.3378.11.camel@localhost.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On 07/03/2009 01:03 PM, Lucas Meneghel Rodrigues wrote: > On Thu, 2009-07-02 at 21:23 -0300, Lucas Meneghel Rodrigues wrote: > >> Ok, I've been trough the test and took a look at the testsuite itself. >> Both look good. The testsuite requires a very current qemu-img package, >> due to the use of qemu-io (F11 for instance doesn't ship it). So if you >> want to try this make sure you use a current version of the kvm >> utilities. >> > It just occurred to me some suggestions based on my last comment: > * Make sure we have the qemu, qemu-img and the qemu-io ELF files > available to execute the test suite, and if we doesn't, raise a > error.TestError() exception. > * Make it possible to specify an alternate prefix to look for those > ELFs, and make sure the test suite can find them (ie, appending the path > to os.environ['PATH']). > > Yolkfull, please take a look at implementing those suggestions. > > Thanks again for your work! > > Lucas > > Lucas, OK, I really forgot to set the PATH of 'qemu', 'qemu-img' and 'qemu-io'. I will do modifications according to your wonderful suggestions. Thank you so much! :-) -- Yolkfull Regards,