From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andre Przywara Subject: Re: [Qemu-devel] [RFC] allow multi-core guests: introduce cores= option to -cpu Date: Sat, 4 Jul 2009 01:28:43 +0200 Message-ID: <4A4E942B.3070207@amd.com> References: <1246632116-31366-1-git-send-email-andre.przywara@amd.com> <20090703145229.GU32062@const.bordeaux.inria.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org To: Samuel Thibault Return-path: Received: from outbound-dub.frontbridge.com ([213.199.154.16]:10974 "EHLO IE1EHSOBE004.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752535AbZGCX1y convert rfc822-to-8bit (ORCPT ); Fri, 3 Jul 2009 19:27:54 -0400 In-Reply-To: <20090703145229.GU32062@const.bordeaux.inria.fr> Sender: kvm-owner@vger.kernel.org List-ID: Samuel Thibault wrote: > Andre Przywara, le Fri 03 Jul 2009 16:41:56 +0200, a =E9crit : >> -smp 16 -cpu host,cores=3D8 >=20 > That means 8 cores with 2 threads each, thus 16 threads? No, that meant: 16 vCPUs total with 8 cores per physical packages. I=20 don't have any notion for threads in the current code, although I agree= =20 that this should be introduced. AFAIK Windows XP Home is limited to one socket, where XP Pro can use up= =20 to two sockets. Using -smp 4 on a XP Pro (64bit) caused an early BSOD=20 stating "MULTIPROCESSOR_CONFIGURATION_NOT_SUPPORTED" (because it saw=20 four sockets instead of four cores). I think WindowsXP Home should even be worse (though I don't have an=20 image here to test it), because it would not boot any SMP guest. > Ok, that can be > later generalized into for instance >=20 > -smp 16 -cpu host,nodes=3D2,sockets=3D2,cores=3D2 >=20 > to define 2 NUMA nodes of 2 sockets of 2 cores, each core thus having= 16 > threads. Well, generalizing is a good idea, but as Brian wrote this shouldn't be= =20 done in the -cpu option. Putting the NUMA nodes into here seems quite=20 logical, but would also requires to a) describe the NUMA topology separated from this option or b) pull all the NUMA topology description into this one. Maybe one could describe cores, threads, sockets and nodes in -smp and=20 declare the memory topology only in -numa. Regards, Andre. --=20 Andre Przywara AMD-Operating System Research Center (OSRC), Dresden, Germany Tel: +49 351 488-3567-12