From: Avi Kivity <avi@redhat.com>
To: Andre Przywara <andre.przywara@amd.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] qemu-kvm: remove "KVM misreports CPUID" hack
Date: Sat, 04 Jul 2009 18:21:05 +0300 [thread overview]
Message-ID: <4A4F7361.2000900@redhat.com> (raw)
In-Reply-To: <1246623839-24572-1-git-send-email-andre.przywara@amd.com>
On 07/03/2009 03:23 PM, Andre Przywara wrote:
> This should be no longer necessary.
> Effectively reverts 143eb2bd043e82bcf353cf82d33c127f06411d82.
>
> Signed-off-by: Andre Przywara<andre.przywara@amd.com>
> ---
> kvm/libkvm/libkvm-x86.c | 9 ---------
> qemu-kvm-x86.c | 9 ---------
> 2 files changed, 0 insertions(+), 18 deletions(-)
>
> Hi Avi,
>
> I am not sure what caused your problem back in May when you committed this,
> but it seems to work without this now. I booted Win7RC 64bit and WinXP 64bit
> and saw no problems.
>
It's necessary for backwards compatibility. Older kvm versions
misreported these bits, so we need to fix them up in userspace.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
prev parent reply other threads:[~2009-07-04 15:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-03 12:23 [PATCH] qemu-kvm: remove "KVM misreports CPUID" hack Andre Przywara
2009-07-04 15:21 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A4F7361.2000900@redhat.com \
--to=avi@redhat.com \
--cc=andre.przywara@amd.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox