From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] qemu-kvm: remove "KVM misreports CPUID" hack Date: Sat, 04 Jul 2009 18:21:05 +0300 Message-ID: <4A4F7361.2000900@redhat.com> References: <1246623839-24572-1-git-send-email-andre.przywara@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Andre Przywara Return-path: Received: from mx2.redhat.com ([66.187.237.31]:56931 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752958AbZGDPVF (ORCPT ); Sat, 4 Jul 2009 11:21:05 -0400 In-Reply-To: <1246623839-24572-1-git-send-email-andre.przywara@amd.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/03/2009 03:23 PM, Andre Przywara wrote: > This should be no longer necessary. > Effectively reverts 143eb2bd043e82bcf353cf82d33c127f06411d82. > > Signed-off-by: Andre Przywara > --- > kvm/libkvm/libkvm-x86.c | 9 --------- > qemu-kvm-x86.c | 9 --------- > 2 files changed, 0 insertions(+), 18 deletions(-) > > Hi Avi, > > I am not sure what caused your problem back in May when you committed this, > but it seems to work without this now. I booted Win7RC 64bit and WinXP 64bit > and saw no problems. > It's necessary for backwards compatibility. Older kvm versions misreported these bits, so we need to fix them up in userspace. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.