public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Sehrawat Nipun <nipun.sehrawat@epfl.ch>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: Using MSR Load/Store Areas
Date: Sun, 05 Jul 2009 11:02:57 +0300	[thread overview]
Message-ID: <4A505E31.8000007@redhat.com> (raw)
In-Reply-To: <C41EE5BD1A770546A82E3100FD1F6EB7095B64C1E4@REX1.intranet.epfl.ch>

On 07/04/2009 12:42 AM, Sehrawat Nipun wrote:
> Hi Everyone,
>
> I am trying to use the MSR load and store areas in vmx. I did following:
>
> 1. Setting vm_entry_msr_load_count:
>
> vmcs_write32(VM_ENTRY_MSR_LOAD_COUNT, 1);
>
> 2. Setting up vm_entry_msr_load_addr :
>
> static struct page *vmx_msr_load;
>
> Then in vmx_init() :
>
> vmx_msr_load = alloc_page(GFP_KERNEL | __GFP_HIGHMEM);
>    

Don't use highmem for pages you give to vmx -- some implementations only 
support 32-bit physical addresses.

> va=kmap(vmx_msr_load);
> memset(va, MSR_P6_PERFCTR0, 32);  /*Bits 31:0 contain msr's address*/
>    

This doesn't do what you think it does.  Look at the resulting memory 
pattern.  Use ordinary assignment instead.

-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2009-07-05  8:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-03 21:42 Using MSR Load/Store Areas Sehrawat Nipun
2009-07-05  8:02 ` Avi Kivity [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-07-03 14:04 Using MSR load/store areas Nipun sehrawat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A505E31.8000007@redhat.com \
    --to=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=nipun.sehrawat@epfl.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox