From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCHv4 4/5] qemu/msi: missing braces
Date: Sun, 05 Jul 2009 15:07:06 +0300
Message-ID: <4A50976A.8040901@redhat.com>
References: <cover.1246793893.git.mst@redhat.com> <20090705114057.GE4798@redhat.com> <f43fc5580907050448w6a254762y51d57f192978da3b@mail.gmail.com> <20090705115601.GA4826@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org,
	kvm@vger.kernel.org, aliguori@us.ibm.com, kwolf@redhat.com,
	glommer@redhat.com
To: "Michael S. Tsirkin" <mst@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:45181 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752340AbZGEME5 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 5 Jul 2009 08:04:57 -0400
In-Reply-To: <20090705115601.GA4826@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 07/05/2009 02:56 PM, Michael S. Tsirkin wrote:
>> With the braces comment I meant that while working on the code, you
>> should update it to match CODING_STYLE:
>> if (!(dev->cap_present&  QEMU_PCI_CAP_MSIX)) {
>>      return;
>> }
>>      
>
> Yea ... it's probably better to do this all over the file, not piecewise,
> though. No?
>    

No, that just causes churn (and merge conflicts for me).  Better to only 
fix if you have a patch that modifies the same place.

-- 
error compiling committee.c: too many arguments to function