From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: x86: Fix KVM_GET_MSR_INDEX_LIST Date: Mon, 06 Jul 2009 10:49:35 +0300 Message-ID: <4A51AC8F.1010707@redhat.com> References: <4A4D0E6B.6090105@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Jan Kiszka Return-path: Received: from mx2.redhat.com ([66.187.237.31]:43983 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752348AbZGFHrS (ORCPT ); Mon, 6 Jul 2009 03:47:18 -0400 In-Reply-To: <4A4D0E6B.6090105@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On 07/02/2009 10:45 PM, Jan Kiszka wrote: > So far, KVM copied the emulated_msrs (only MSR_IA32_MISC_ENABLE) to a > wrong address in user space due to broken pointer arithmetic. This > caused subtle corruption up there (missing MSR_IA32_MISC_ENABLE had > probably no practical relevance). Moreover, the size check for the > user-provided kvm_msr_list forgot about emulated MSRs. > Applied, thanks. And ouch. -- error compiling committee.c: too many arguments to function