From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Revert "KVM: x86: check for cr3 validity in ioctl_set_sregs" Date: Mon, 06 Jul 2009 10:55:31 +0300 Message-ID: <4A51ADF3.3000900@redhat.com> References: <4A4BB053.6010407@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm-devel To: Jan Kiszka Return-path: Received: from mx2.redhat.com ([66.187.237.31]:35908 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752330AbZGFHxM (ORCPT ); Mon, 6 Jul 2009 03:53:12 -0400 In-Reply-To: <4A4BB053.6010407@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On 07/01/2009 09:52 PM, Jan Kiszka wrote: > This reverts commit 6c20e1442bb1c62914bb85b7f4a38973d2a423ba. > > To my understanding, it became obsolete with the advent of the more > robust check in mmu_alloc_roots (89da4ff17f). Moreover, it prevents > the conceptually safe pattern > > 1. set sregs > 2. register mem-slots > 3. run vcpu > > by setting a sticky triple fault during step 1. > > Applied, thanks. -- error compiling committee.c: too many arguments to function