From: Avi Kivity <avi@redhat.com>
To: "Dong, Eddie" <eddie.dong@intel.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: EOI acceleration for high bandwidth IO
Date: Mon, 06 Jul 2009 17:53:51 +0300 [thread overview]
Message-ID: <4A520FFF.1030908@redhat.com> (raw)
In-Reply-To: <9832F13BD22FB94A829F798DA4A8280501B9CF5445@pdsmsx503.ccr.corp.intel.com>
On 07/06/2009 05:34 PM, Dong, Eddie wrote:
> Avi Kivity wrote:
>
>> On 07/06/2009 04:42 PM, Dong, Eddie wrote:
>>
>>> EOI is one of key VM Exit at high bandwidth IO such as VT-d
>>> with 10Gb/s NIC. This patch accelerate guest EOI emulation
>>> utilizing HW VM Exit information.
>>>
>>>
>> Won't this fail if the guest uses STOSD to issue the EOI?
>>
>>
> Good catch, should we use an exclusion list for the opcode?
>
That means fetching the opcode and doing partial decoding, which will
negate the advantage.
> Or use decode cache for hot IP (RO in EPT for gip)?
>
How can you tell if the code did not change?
I think it's reasonable to assume that the guest won't use STOSD for EOI
though, and to apply your patch. There's no risk to the host.
> We noticed huge amount of vEOI in 10Gb/s NIC which is ~70KHZ for EOI.
> With SR-IOV, it could go up much more to even million level. Decode and
> emulation cost 7K cycles, while short path may only spend 3-4K cycles.
>
Yes, and I think we can drop the short path further to almost zero by
using paravirtualization. It would work for Linux and Windows x86 (with
something similar to tpr patching). Unfortunately it won't work on
Windows x64 since it doesn't allow patching.
We can also expose x2apic (already merged) or Hyper-V enlightenment
which converts EOI to MSR write which is fairly fast.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-07-06 14:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-06 9:34 bridge + KVM performance Martin Petermann
2009-07-06 11:53 ` Dor Laor
2009-07-06 13:42 ` EOI acceleration for high bandwidth IO Dong, Eddie
2009-07-06 14:03 ` Avi Kivity
2009-07-06 14:34 ` Dong, Eddie
2009-07-06 14:53 ` Avi Kivity [this message]
2009-07-06 19:27 ` bridge + KVM performance Martin Petermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A520FFF.1030908@redhat.com \
--to=avi@redhat.com \
--cc=eddie.dong@intel.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox