Re: [PATCHv3] qemu-kvm: enable msi with irqchip

[Avi Kivity <avi@redhat.com>]

On 07/05/2009 09:52 PM, Michael S. Tsirkin wrote:
>
>>> +		switch (e->type)
>>> +		{
>>> +		case KVM_IRQ_ROUTING_IRQCHIP: {
>>> +			if (e->u.irqchip.irqchip ==
>>> +			    entry->u.irqchip.irqchip
>>> +			&&   e->u.irqchip.pin ==
>>> +			    entry->u.irqchip.pin) {
>>> +			    found = 1;
>>> +                        }
>>>
>>>        
>> this
>> is
>> not
>> readable
>>      
>
> OK, but other functions in this file look the same.
>    

I don't know how they sneaked them past me.  Ignore the others.

>> You use perror() on functions that return -errno; please fix.
>>      
>
> Should I send output to stderr or to console, btw?
>    

stderr for now.  When we have the new monitor protocol we can define a 
notification for logging random errors.

-- 
error compiling committee.c: too many arguments to function