From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCHv3] qemu-kvm: enable msi with irqchip Date: Tue, 07 Jul 2009 14:27:00 +0300 Message-ID: <4A533104.3040004@redhat.com> References: <20090705173545.GA9882@redhat.com> <4A50EAD4.8010800@redhat.com> <20090705185259.GA3275@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: "Michael S. Tsirkin" Return-path: Received: from mx2.redhat.com ([66.187.237.31]:54435 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752301AbZGGLYd (ORCPT ); Tue, 7 Jul 2009 07:24:33 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n67BOcdp026704 for ; Tue, 7 Jul 2009 07:24:38 -0400 In-Reply-To: <20090705185259.GA3275@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/05/2009 09:52 PM, Michael S. Tsirkin wrote: > >>> + switch (e->type) >>> + { >>> + case KVM_IRQ_ROUTING_IRQCHIP: { >>> + if (e->u.irqchip.irqchip == >>> + entry->u.irqchip.irqchip >>> + && e->u.irqchip.pin == >>> + entry->u.irqchip.pin) { >>> + found = 1; >>> + } >>> >>> >> this >> is >> not >> readable >> > > OK, but other functions in this file look the same. > I don't know how they sneaked them past me. Ignore the others. >> You use perror() on functions that return -errno; please fix. >> > > Should I send output to stderr or to console, btw? > stderr for now. When we have the new monitor protocol we can define a notification for logging random errors. -- error compiling committee.c: too many arguments to function